Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return type for GLTFLoader's parseAsync method #224

Merged
merged 1 commit into from
Jun 14, 2022
Merged

fix: return type for GLTFLoader's parseAsync method #224

merged 1 commit into from
Jun 14, 2022

Conversation

capnmidnight
Copy link
Contributor

Why

GLTFLoader::parseAsync() indicates a Promise<void> return type, which is incorrect

What

Change GLTFLoader::parseAsync() to return Promise<GLTF>.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

joshuaellis
joshuaellis requested changes Jun 14, 2022
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a question than a change.

types/three/examples/jsm/loaders/GLTFLoader.d.ts Show resolved Hide resolved
@joshuaellis joshuaellis changed the title Fix the return type for GLTFLoader's parseAsync method fix: return type for GLTFLoader's parseAsync method Jun 14, 2022
@joshuaellis joshuaellis merged commit fe6bc9b into three-types:master Jun 14, 2022
@capnmidnight capnmidnight deleted the fix-GLTFLoader-return-type branch June 14, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capnmidnight @joshuaellis