Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[postprocessing] Some SSAARenderPass arguments are optional #197

Merged
merged 1 commit into from
Mar 20, 2022
Merged

[postprocessing] Some SSAARenderPass arguments are optional #197

merged 1 commit into from
Mar 20, 2022

Conversation

willstott101
Copy link
Contributor

Why

SSAARenderPass implementation is robust to undefined for the last two arguments

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table - not really bothered tbh, github keeps track anyway?
  • Ready to be merged

@willstott101 willstott101 mentioned this pull request Mar 11, 2022
Closed
7 tasks
joshuaellis
joshuaellis approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! ⭐

@joshuaellis joshuaellis merged commit 5aeb0ff into three-types:master Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willstott101 @joshuaellis