Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds CapsuleGeometry definitions #194

Merged
merged 2 commits into from
Mar 3, 2022
Merged

feat: adds CapsuleGeometry definitions #194

merged 2 commits into from
Mar 3, 2022

Conversation

gsimone
Copy link
Contributor

@gsimone gsimone commented Mar 1, 2022 •
edited
Loading

Why

What

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@gsimone gsimone changed the title Create CapsuleGeometry.d.ts feat: add CapsuleGeometry definitions Mar 1, 2022
@gsimone gsimone changed the title feat: add CapsuleGeometry definitions feat: adds CapsuleGeometry definitions Mar 1, 2022
joshuaellis
joshuaellis approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

@gsimone
Copy link
Contributor Author

gsimone commented Mar 1, 2022

Gotta add it to the import 👍

@0b5vr
Copy link
Contributor

0b5vr commented Mar 3, 2022

mrdoob/three.js#23586

@joshuaellis
Copy link
Member

@all-contributors add @gsimone for code

@allcontributors allcontributors bot mentioned this pull request Mar 3, 2022
Merged
@allcontributors
Copy link
Contributor

@joshuaellis

I've put up a pull request to add @gsimone! 🎉

@joshuaellis joshuaellis merged commit 8b52c61 into three-types:dev Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsimone @0b5vr @joshuaellis