feature (Texture): Add Source class #180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To catch up with r138 changes
What
Added
Source
class that is going to be introduced in r138.I also added a test code
textures-source.ts
.See: mrdoob/three.js#22846
See: mrdoob/three.js#23419
Points need review
I have very low confidence about the signature ofSource.data
andTexture.image
@Mugen87 would you mind reviewing this?I don't fully understand howSource
works with video textures, compressed textures, ...any
for now.Is it reasonable to define a typeSourceData
?Checklist
master
, next goesdev
)