Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VRMLoader #179

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Remove VRMLoader #179

merged 1 commit into from
Mar 1, 2022

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Feb 22, 2022

Why

To catch up with r138 changes

What

Remove VRMLoader.

See: mrdoob/three.js#23414

(clarification: it was an implementation of VRM which was not maintained. as mrdoob mentions, people should use @pixiv/three-vrm instead.)

Question

What was the purpose of OTHER_FILES.txt again?
I kinda want to document this in a separated PR since I forgot 😅

Checklist

  • Checked the target branch (current goes master, next goes dev)
    • it's a r138 change so it should be directed to dev
  • Added myself to contributors table
  • Ready to be merged

@0b5vr 0b5vr mentioned this pull request Feb 22, 2022
16 tasks
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's basically to say that these files are included in the type system but aren't accessed by the source, i'm not sure more than that unfortunately.

@joshuaellis joshuaellis merged commit 89d5477 into three-types:dev Mar 1, 2022
@0b5vr 0b5vr deleted the vrm branch March 1, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants