Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update PULL_REQUEST_TEMPLATE #166

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Jan 27, 2022

Why

Because I picked the wrong target branch all the time

Low confidence PR since I'm not sure others also need this checkbox as well

What

Add "Checked the target branch" on the checklist.

Points need review

  • English grammar
    • I suck at English

Checklist

  • Added myself to contributors table
  • Ready to be merged

Add "Checked the target branch" on the checklist
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart addition, thank you.

@joshuaellis joshuaellis merged commit 412f6bc into three-types:master Jan 27, 2022
@0b5vr 0b5vr deleted the patch-1 branch January 27, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants