Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change (Texture): Add needsPMREMUpdate #165

Merged
merged 1 commit into from
Mar 1, 2022
Merged

change (Texture): Add needsPMREMUpdate #165

merged 1 commit into from
Mar 1, 2022

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Jan 27, 2022

Why

To catch up with r137

What

  • Add .needsPMREMUpdate to Texture .
    • I believe the change is missing from 229bf59 .
    • It's kind of internal code so it's not urgent I think.

See: https://github.com/mrdoob/three.js/pull/23152/files#diff-175700535db017573bbec67a2dfcd5ff8185413f73de5a98bf394a017e181db0R74

Checklist

  • Added myself to contributors table
  • Ready to be merged

@joshuaellis joshuaellis merged commit 49dbf57 into three-types:master Mar 1, 2022
@0b5vr 0b5vr deleted the needspmremupdate branch March 1, 2022 10:14
gsimone pushed a commit to gsimone/three-ts-types that referenced this pull request Mar 1, 2022
@0b5vr @gsimone
change (Texture): Add needsPMREMUpdate (three-types#165)
1d376fa 
Since it's undocumented there is no doc comment

See: https://github.com/mrdoob/three.js/pull/23152/files#diff-175700535db017573bbec67a2dfcd5ff8185413f73de5a98bf394a017e181db0R74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0b5vr @joshuaellis