Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orbitcontrols add types #157

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

LauferAlex
Copy link
Contributor

Why

Adding missign types to the OrbitControls example. Problem arrises when the .saveState and reset methods are used and access to the target0, position0 and zoom0 properties is sought but they are not publicly accesible.

What

Definition added for:

target0: Vector3; 
position0: Vector3; 
zoom0: number;

Checklist

  • Added myself to contributors table
  • Ready to be merged

@joshuaellis joshuaellis merged commit ff055d1 into three-types:master Jan 13, 2022
@LauferAlex LauferAlex deleted the orbitcontrols-add-types branch January 13, 2022 14:42
@LauferAlex
Copy link
Contributor Author

Thank you for accepting my pull request. Currently, I'm working in a project and a I would like to know if you can tell how much time is going to take updating the definitions of DefinitelyTyped of Three?
@joshuaellis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants