Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(@types/three): AnimationClip#toJSON method patch #1492

Merged
merged 1 commit into from
Jan 7, 2025
Merged

refactor(@types/three): AnimationClip#toJSON method patch #1492

merged 1 commit into from
Jan 7, 2025

Conversation

Neosoulink
Copy link
Contributor

Summary

This PR is the resolution of [@types/three]: AnimationClip toJSON method is not accurate discussion.

Changes

  • Remove AnimationClip#toJSON method parameter
  • Replace the return any type with the AnimationClipJson type

@Neosoulink
refactor(@types/three): AnimationClip#toJSON method patch
e64ff6f 
### Description

- Remove paramter to the `AnimationClip#toJSON` method
- Replace the return `any` type with the `AnimationClipJson` type
Methuselah96
Methuselah96 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96 Methuselah96 merged commit 7fc7c84 into three-types:master Jan 7, 2025
5 checks passed
@Methuselah96
Copy link
Contributor

This will be released at the end of the month with r173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Methuselah96 Methuselah96 Methuselah96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Neosoulink @Methuselah96