Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing onUpload and onUploadCallback on InterleavedBuffer #1373

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Add missing onUpload and onUploadCallback on InterleavedBuffer #1373

merged 1 commit into from
Nov 24, 2024

Conversation

eiriklegernaes
Copy link
Contributor

This PR adds onUpload and onUploadCallback to InterleavedBuffer. Both BufferAttribute and InterleavedBuffer have these functions, but only the former had types for them.

@Methuselah96
Copy link
Contributor

Thanks!

@Methuselah96 Methuselah96 merged commit 9f275a9 into three-types:master Nov 24, 2024
5 checks passed
@Methuselah96 Methuselah96 mentioned this pull request Dec 12, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Methuselah96 Methuselah96 Methuselah96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eiriklegernaes @Methuselah96