fix: add null to Material.shadowSide's type #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it possible to work with Material.shadowSide's default value of null.
joshuaellis
approved these changes
Oct 3, 2021
joshuaellis
added a commit
that referenced
this pull request
Nov 6, 2021
* fix: add null to Material.shadowSide's type (#131) This change makes it possible to work with Material.shadowSide's default value of null. * feat: Make Raycaster::Intersection, intersectObject generic (#130) Co-authored-by: Josh <[email protected]> * fix: remove ParametricGeometries from OTHER_FILES.txt * chore: update OTHER_FILES weird this didn't come through earlier. * chore: update deps * fix: undefined not needed on ArcballControls * feat: include default Object3D in Intersection generic type (#138) * r133 - include default Object3D in intersection generic type * [yarn] - updated lockfile Co-authored-by: Dave Buchhofer <[email protected]> * chore: modify test for generic * Add resolveURL to LoaderUtils Co-authored-by: Ibby Wedin <[email protected]> Co-authored-by: Degubi <[email protected]> Co-authored-by: Josh <[email protected]> Co-authored-by: Dave Buchhofer <[email protected]> Co-authored-by: Dave Buchhofer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently not possible to work with
Material.shadowSide's default value of null, as property's type does not includenull.This commit changes the type of
Material.shadowSidefromSidetoSide | null.