Strongly type Texture.mipmaps #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HunterLarco
reviewed
Jun 24, 2024
| @@ -72,7 +72,7 @@ export class CompressedTexture extends Texture { | |||
| * The mipmaps array should contain objects with data, width and height. The mipmaps should be of the correct | |||
| * format and type. | |||
| */ | |||
| mipmaps: CompressedTextureMipmap[]; | |||
| mipmaps: CompressedTextureMipmap[] | undefined; | |||
There was a problem hiding this comment.
I'm not sure mipmaps actually can be undefined here?
https://github.com/mrdoob/three.js/blob/dev/src/textures/CompressedTexture.js#L12
There was a problem hiding this comment.
CompressedCubeTexture sets it to undefined here. 😢
There was a problem hiding this comment.
That is deeply unfortunate 😢 but nice catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing
Texture.mipmapsasany[]is too loose.