Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Some Declarations Might be @deprecated #174

Closed
10 tasks done
ycw opened this issue Feb 17, 2022 · 7 comments · Fixed by #176
Closed
10 tasks done

Issue: Some Declarations Might be @deprecated #174

ycw opened this issue Feb 17, 2022 · 7 comments · Fixed by #176
Labels
bug Something isn't working

Comments

@ycw
Copy link
Contributor

ycw commented Feb 17, 2022

Please help checking if the following declarations did exist before (=adds @deprecated),

or they're declared wrongly in the first place (=removes declarations)

Animation

AnimationUtils (src)

Core

BufferGeometry (src)

InstancedBufferGeometry (src)

Uniform (src)

Scenes

Scene (src)

  • onBeforeRender (inherit)
  • onAfterRender (inherit)

Math

Plane (src)

Textures

DataTexture (src)

  • format (override; should keep)

Renderers

WebGLRenderTarget (src)

@ycw ycw added the bug Something isn't working label Feb 17, 2022
@joshuaellis
Copy link
Member

Thanks @ycw,

if you do spot issues like this then it's helpful to just make PRs instead to resolve them!

In reference to your Math/Euler pull out, thats actually on the dev branch and we're not working on implementing new types until closer to the time.

@ycw
Copy link
Contributor Author

ycw commented Feb 19, 2022

@joshuaellis it's something I would expect the community to contribute to 😃

could you reopen it.

@joshuaellis
Copy link
Member

Can you first edit the comment (i've made some stylistic changes to help readability) to include references to what you're talking about. I think this must be a requirement if we're going to keep a list like this.

@ycw
Copy link
Contributor Author

ycw commented Feb 19, 2022

@joshuaellis edited, thanks!

@joshuaellis
Copy link
Member

@joshuaellis edited, thanks!

Do you have links to the THREE source code to add to these?

@ycw
Copy link
Contributor Author

ycw commented Feb 19, 2022

@joshuaellis added links to src (r137)

@joshuaellis joshuaellis reopened this Feb 19, 2022
@ycw
Copy link
Contributor Author

ycw commented Feb 19, 2022

@joshuaellis updated src links to use master

ycw added a commit to ycw/three-ts-types that referenced this issue Feb 19, 2022
@ycw ycw mentioned this issue Feb 19, 2022
3 tasks
joshuaellis pushed a commit that referenced this issue Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants