Okx: Fix sending trades to the websocket DataHandler #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the test to process trades for each asset type Add raw trade data from OKX Update the timestamp in the method
shazbert
requested changes
Mar 9, 2025
exchanges/okx/okx_test.go
Outdated
Comment on lines
4055
to
4056
| instrumentID := "BTC-USDT" | ||
| assets, err := ok.getAssetsFromInstrumentID(instrumentID) |
There was a problem hiding this comment.
Suggested change
| instrumentID := "BTC-USDT" | |
| assets, err := ok.getAssetsFromInstrumentID(instrumentID) | |
| assets, err := ok.getAssetsFromInstrumentID("BTC-USDT") |
exchanges/okx/okx_test.go
Outdated
Comment on lines
4093
to
4094
| require.Len(t, ok.Websocket.DataHandler, total, | ||
| "Must see correct number of trades") |
There was a problem hiding this comment.
Suggested change
| require.Len(t, ok.Websocket.DataHandler, total, | |
| "Must see correct number of trades") | |
| require.Len(t, ok.Websocket.DataHandler, total, "Must see correct number of trades") |
exchanges/okx/okx_test.go
Outdated
Comment on lines
4097
to
4099
| for _, a := range assets { | ||
| receivedTrades[a] = []trade.Data{} | ||
| } |
exchanges/okx/okx_test.go
Outdated
Comment on lines
4116
to
4117
| require.Len(t, trades, len(exp), | ||
| "Should have received %d trades for asset %v", len(exp), assetType) |
There was a problem hiding this comment.
Suggested change
| require.Len(t, trades, len(exp), | |
| "Should have received %d trades for asset %v", len(exp), assetType) | |
| require.Len(t, trades, len(exp), "Should have received %d trades for asset %v", len(exp), assetType) |
exchanges/okx/okx_test.go
Outdated
Comment on lines
4114
to
4115
| trades, exists := receivedTrades[assetType] | ||
| require.True(t, exists, "Should have received trades for asset %v", assetType) |
There was a problem hiding this comment.
This exists check is handled below by the trades length check and can be removed
exchanges/okx/okx_test.go
Outdated
Comment on lines
4124
to
4126
| require.Equal(t, expected, trade, | ||
| "Trade %d (TID: %s) for asset %v should match expected data", | ||
| i, trade.TID, assetType) |
There was a problem hiding this comment.
Suggested change
| require.Equal(t, expected, trade, | |
| "Trade %d (TID: %s) for asset %v should match expected data", | |
| i, trade.TID, assetType) | |
| require.Equal(t, expected, trade, "Trade %d (TID: %s) for asset %v should match expected data", i, trade.TID, assetType) |
| return trade.AddTradesToBuffer(trades...) | ||
| if tradeFeed { | ||
| for i := range trades { | ||
| ok.Websocket.DataHandler <- trades[i] |
There was a problem hiding this comment.
OOS: In trade.go under method Update we are passing the entire slice which can be updated to only send through individual updates. If you want to use this function to cut down on some code you are more than welcome. ok.Websocket.Trade.Update(...)
There was a problem hiding this comment.
Will leave this out of this PR if that's ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Trades are not being sent down to the websocket DataHandler because the IsTradeFeedEnabled is not set.
Additional changes:
Type of change
Please delete options that are not relevant and add an
xin[]as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist