Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okx: move WsResponseMultiplexer to setDefaults #1829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

junnplus
Copy link
Contributor

@junnplus junnplus commented Mar 7, 2025

PR Description

The WsResponseMultiplexer structure should be initialized in setDefaults method.

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.

  • go test ./... -race
  • golangci-lint run
  • Test X

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Github Actions with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes ACK. I am going to be removing this multiplexer when I get a chance to rebase from this PR FYI. If you would like this as a priority let me know @junnplus ?

@junnplus
Copy link
Contributor Author

@shazbert Thanks for the update. I see that your PR might not be merged soon. If possible, I’d like my changes to be allowed first, as I prefer not to rely on the Setup method to start the exchange.

@shazbert
Copy link
Collaborator

@shazbert Thanks for the update. I see that your PR might not be merged soon. If possible, I’d like my changes to be allowed first, as I prefer not to rely on the Setup method to start the exchange.

Yeah, this will be merged first 👍 if you would like the other PR merged as a priority let me know and I can undertake a rebase later this week.

@shazbert shazbert added review me This pull request is ready for review szrc shazbert review complete labels Mar 10, 2025
Copy link
Collaborator

@gbjk gbjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Collaborator

@thrasher- thrasher- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junnplus confirming that this will be merged first 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me This pull request is ready for review szrc shazbert review complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants