-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
okx: move WsResponseMultiplexer to setDefaults #1829
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ye Sijun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shazbert Thanks for the update. I see that your PR might not be merged soon. If possible, I’d like my changes to be allowed first, as I prefer not to rely on the Setup method to start the exchange. |
Yeah, this will be merged first 👍 if you would like the other PR merged as a priority let me know and I can undertake a rebase later this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junnplus confirming that this will be merged first 👍
PR Description
The
WsResponseMultiplexer
structure should be initialized insetDefaults
method.Type of change
Please delete options that are not relevant and add an
x
in[]
as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist