-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bybit: support categorised channel #1823
Conversation
Signed-off-by: Ye Sijun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks heaps @junnplus. Looks good to me! I don't have any funds so incoming changes did not test.
{"req_id":"108432952","success":true,"ret_msg":"","op":"subscribe","conn_id":"cthsbl8f2tdpsfl4bdgg-1hkjbt"}
With payload:
{auth:true RequestID:108432952 Operation:subscribe Arguments:[execution.spot order.spot wallet]
Master outbound which didn't have the specific categorised topic in args:
{auth:true RequestID:122744171 Operation:subscribe Arguments:[execution order wallet]
@@ -65,7 +65,6 @@ var defaultSubscriptions = subscription.List{ | |||
{Enabled: true, Asset: asset.Spot, Authenticated: true, Channel: subscription.MyOrdersChannel}, | |||
{Enabled: true, Asset: asset.Spot, Authenticated: true, Channel: subscription.MyWalletChannel}, | |||
{Enabled: true, Asset: asset.Spot, Authenticated: true, Channel: subscription.MyTradesChannel}, | |||
{Enabled: true, Asset: asset.Spot, Authenticated: true, Channel: chanPositions}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: This is associated with linear/inverse/options and can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was going to be my first question 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work and useful contribution 🎉
One minor suggestion, but approved as is as well.
Co-authored-by: Gareth Kirwan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! Thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @junnplus for your contributions!
PR Description
Enhance Bybit private channel subscription with categorised topics
ref: https://bybit-exchange.github.io/docs/v5/websocket/private/position
Fixes # (issue)
Type of change
Please delete options that are not relevant and add an
x
in[]
as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist