Kraken: Fix sending trades to the websocket DataHandler #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the tradeFeed is enabled, send the trades down the DataHandler Add TestWSProcessTrades
thrasher-
changed the title
thrasher-
requested review from
gloriousCode,
thrasher- and
gbjk
and removed request for
gloriousCode
shazbert
requested changes
Feb 24, 2025
| @@ -531,7 +531,10 @@ func (k *Kraken) wsProcessTrades(response []any, pair currency.Pair) error { | |||
| if !ok { | |||
| return errors.New("received invalid trade data") | |||
| } | |||
| if !k.IsSaveTradeDataEnabled() { | |||
| saveTradeData := k.IsSaveTradeDataEnabled() | |||
| tradeFeed := k.IsTradeFeedEnabled() | |||
There was a problem hiding this comment.
OOS: Just highlighting this as trade feed enabled is not necessary as it's a subscription customisation. No change needed.
gbjk
requested changes
Feb 28, 2025
Send individual trades down the DataHandler Send multiple trades in test Test error if the trade length is too short Nits
gbjk
approved these changes
Mar 2, 2025
15 tasks
thrasher-
requested changes
Mar 3, 2025
exchanges/kraken/kraken_test.go
Outdated
| i := 1 - len(k.Websocket.DataHandler) | ||
| exp := trade.Data{Exchange: k.Name, CurrencyPair: spotTestPair} | ||
| require.NoErrorf(t, json.Unmarshal([]byte(expJSON[i]), &exp), "Must not error unmarshalling json %d: %s", i, expJSON[i]) | ||
| require.Equalf(t, exp, v, "Trade [%d] should be correct", i) |
There was a problem hiding this comment.
Suggested change
| require.Equalf(t, exp, v, "Trade [%d] should be correct", i) | |
| require.Equalf(t, exp, v, "Trade [%d] must be correct", i) |
common/common.go
Outdated
| @@ -72,6 +72,7 @@ var ( | |||
| ErrUnknownError = errors.New("unknown error") | |||
| ErrGettingField = errors.New("error getting field") | |||
| ErrSettingField = errors.New("error setting field") | |||
| ErrParsingWSField = errors.New("error parsing WS field") | |||
There was a problem hiding this comment.
Suggested change
| ErrParsingWSField = errors.New("error parsing WS field") | |
| ErrParsingWSField = errors.New("error parsing websocket field") |
This wasn't your doing, but I'd prefer that we don't use acronyms for error messages
There was a problem hiding this comment.
No worries, I originally wrote "websocket" but changed it when I saw the original errors 😄 . Updated
exchanges/bitfinex/bitfinex_test.go
Outdated
| @@ -1997,7 +1997,7 @@ func TestGetErrResp(t *testing.T) { | |||
| seen++ | |||
| switch seen { | |||
| case 1: // no event | |||
| assert.ErrorIs(t, testErr, errParsingWSField, "Message with no event Should get correct error type") | |||
| assert.ErrorIs(t, testErr, common.ErrParsingWSField, "Message with no event Should get correct error type") | |||
There was a problem hiding this comment.
Suggested change
| assert.ErrorIs(t, testErr, common.ErrParsingWSField, "Message with no event Should get correct error type") | |
| assert.ErrorIs(t, testErr, common.ErrParsingWSField, "Message with no event should get correct error type") |
thrasher-
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Currently, the Kraken trades are not streaming via the websocket.
Fix: when the tradeFeed is set to
true, send the data down to the WebSocket DataHandler. Add a test.Fixes # (issue)
Type of change
Please delete options that are not relevant and add an
xin[]as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist