Config: Fix config version downgrade #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbjk
force-pushed
the
bugfix/config_downgrade
branch
from
df0de84 to
8457cb1
Compare
gbjk
added
reconstructing
|
Pulling out the os.Exit and replacing with testable pathway. |
gbjk
force-pushed
the
bugfix/config_downgrade
branch
2 times, most recently
from
a8dbd89 to
82174cf
Compare
gbjk
added
review me
|
That's better, and testable. |
shazbert
requested changes
Jan 19, 2025
shazbert
requested changes
Jan 20, 2025
Linter fixed :) |
gloriousCode
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
tACK! tested both encrypted and unencrypted
😆
go run . --edit --version=-21 downgrade
GoCryptoTrader: config-helper tool
2025/02/17 13:29:06 Running downgrade from config version 2
2025/02/17 13:29:06 Running downgrade from config version 1
2025/02/17 13:29:06 Running downgrade from config version 0
2025/02/17 13:29:06 Running downgrade from config version -1
panic: runtime error: index out of range [-1]
goroutine 1 [running]:
github.com/thrasher-corp/gocryptotrader/config/versions.(*manager).Deploy(0x1029d4900, {0x1027f9b00, 0x1029fcbe0}, {0x14000400000, 0x757c6, 0x757c7}, 0xffffffffffffffeb)
/Users/WIF/go/src/github.com/thrasher-corp/gocryptotrader/config/versions/versions.go:117 +0xd58
main.main()
/Users/WIF/go/src/github.com/thrasher-corp/gocryptotrader/cmd/config/config.go:90 +0xa00
exit status 2
|
@gloriousCode I know you didn't ask for it but ... Fixed gbjk@2184f0672 |
thrasher-
requested changes
Feb 19, 2025
There was a problem hiding this comment.
go run . upgrade --edit --in=../../config_example.json --out=../../config_example.json
GoCryptoTrader: config-helper tool
2025/02/19 17:30:43 Running upgrade to config version 0
2025/02/19 17:30:43 Running upgrade to config version 1
2025/02/19 17:30:43 Running upgrade to config version 2
2025/02/19 17:30:43 Version management finished
Success! File written to ../../config_example.json
go run . downgrade --version=1 --edit --in=../../config_example.json --out=../../config_example.json
GoCryptoTrader: config-helper tool
2025/02/19 17:31:12 Running downgrade from config version 2
2025/02/19 17:31:12 Version management finished
Success! File written to ../../config_example.json
Same above works for both an encrypted config!
An issue I found when testing this on a fresh config_example.json:
go run . downgrade --version=5 --edit --in=../../config_example.json --out=../../config_example.json
GoCryptoTrader: config-helper tool
2025/02/19 17:27:51 Running upgrade to config version 0
2025/02/19 17:27:51 Running upgrade to config version 1
2025/02/19 17:27:51 Running upgrade to config version 2
2025/02/19 17:27:51 Running upgrade to config version 3
panic: runtime error: index out of range [3] with length 3
goroutine 1 [running]:
github.com/thrasher-corp/gocryptotrader/config/versions.(*manager).Deploy(0xb30e80, {0x8ef1a0, 0xb784e0}, {0xc000380000, 0x32395, 0x32396}, 0x5)
/go/src/github.com/thrasher-corp/gocryptotrader/config/versions/versions.go:117 +0x12cd
main.main()
/go/src/github.com/thrasher-corp/gocryptotrader/cmd/config/config.go:94 +0xb52
exit status 2
At some point I want to add fuzzing to GCT, so this is a good thing to resolve even though it's a funny user request
|
Thanks! Fixed gbjk@8b9dbe47f |
Because this isn't really a file, it's a byte slice
Because it's not actually a file
gbjk
force-pushed
the
bugfix/config_downgrade
branch
from
8b9dbe4 to
4904098
Compare
thrasher-
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1769 and issue raised on #1735
Type of change
How has this been tested