-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exchanges: Add dynamic function checking to determine exchange functionality #1619
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1619 +/- ##
==========================================
+ Coverage 36.36% 36.39% +0.03%
==========================================
Files 422 424 +2
Lines 183105 183221 +116
==========================================
+ Hits 66588 66692 +104
- Misses 108475 108481 +6
- Partials 8042 8048 +6
|
This PR is stale because it has been open 30 days with no activity. Please provide an update on the progress of this PR. |
This PR is stale because it has been open 30 days with no activity. Please provide an update on the progress of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a worthwhile feature to expand across the exchanges now. I like automation
var supported bool
if butts, ok := b.ProtocolCapabilities[protocol.Target{
Asset: asset.Spot,
Protocol: protocol.REST,
}]; ok {
supported = butts.AccountBalance
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done with the revamp. Looks like BTC markets needs a looky and then you're good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tHANKS
Co-authored-by: Scott <[email protected]>
Co-authored-by: Scott <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
PR Description
AutomaticPreFlightCheck
function to determine functionality support between protocols and asset types.Type of change
Please delete options that are not relevant and add an
x
in[]
as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist