-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding notification webhook structure #120
Adding notification webhook structure #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for the contribution! Do you mind adding a test covering the new Webhook in alerts_test.go
?
Test added! |
I'm also planning on creating a PR within the terraform-provider-thousandeyes repo. @pedro-te @raul-te @sfreitas-te may I have a code owner review when possible please. Thank you all for your work! |
00f56d1
Thanks for contributing 😄 |
Thanks for approvals and merging. Do you know when there will be a new release? @joaomper-TE @shahid-te |
Done. Your changes are in v2.4.2. We'll also update this version in |
Any updates on when |
We are in release freeze due to the holidays and will release in January beginning. Apologies for any inconvenience. |
Hi @shahid-te, will there be a new terraform provider release this week? |
Hey @cbhoffman , sorry for the long wait as we were all on 2 weeks of PTO. Will release a new version of TF provider today over this PR: thousandeyes/terraform-provider-thousandeyes#163 |
This aims to ultimately support using webhooks for integrations within the ThousandEyes terraform provider.
Currently, if you create a custom webhook integration (for example, Microsoft Teams), you can't use it to create/update alert rules with webhook notifications (using an integration data source in terraform).
I think there just needs to be an additional struct, if this is wrong please let me know.
Any feedback would be appreciated!