Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codeowners #369

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: codeowners #369

merged 1 commit into from
Apr 10, 2024

Conversation

setchy
Copy link
Contributor

@setchy setchy commented Apr 10, 2024

From past nightmares experience, codeowners need to be on the same line otherwise the last match survives 😅

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax

If you want to match two or more code owners with the same pattern, all the code owners must be on the same line. If the code owners are not on the same line, the pattern matches only the last mentioned code owner.

@marisahoenig
Copy link
Member

Haha thanks for catching, @setchy 😅 I didn't realize

@marisahoenig marisahoenig merged commit 3174c8d into thoughtworks:master Apr 10, 2024
2 checks passed
@setchy
Copy link
Contributor Author

setchy commented Apr 10, 2024

Haha thanks for catching, @setchy 😅 I didn't realize

You're welcome. I'm ashamed to say how many hrs I've spent on this recently haha

@setchy setchy deleted the fix/codeowners branch April 10, 2024 22:25
@setchy
Copy link
Contributor Author

setchy commented Apr 15, 2024

Seems as though @will-amaral is the only person being added as reviewers to PRs.

Is @thoughtworks/tw-digital a private team? If so, this may explain why they're not appearing

When the code owner is a team, that team must be visible and it must have write permissions, even if all the individual members of the team already have write permissions directly, through organization membership, or through another team membership.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants