Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Prepare release for v5.0.0 #1991

Closed
wants to merge 1 commit into from
Closed

Prepare release for v5.0.0 #1991

wants to merge 1 commit into from

Conversation

tute
Copy link
Contributor

@tute tute commented Sep 5, 2015

There are two backward incompatible changes.

cc @jyurek @iwz

@tute tute force-pushed the tc-release branch 2 times, most recently from f6bae8b to 8b49bc5 Compare September 5, 2015 22:05
@maclover7
Copy link
Contributor

Should we hold off on releasing this until Rails 5 lands, I think we are planning on dropping support for 3.2 as apart of that release?

@iwz
Copy link

iwz commented Sep 6, 2015

There was a fix for Rails 3.2 I'd like to get into a release. Maybe we can
cut from there?

On Sat, Sep 5, 2015, 9:24 PM Jon Moss [email protected] wrote:

Should we hold off on releasing this until Rails 5 lands, I think we are
planning on dropping support for 3.2 as apart of that release?


Reply to this email directly or view it on GitHub
#1991 (comment)
.

@tute
Copy link
Contributor Author

tute commented Sep 6, 2015

There was a fix for Rails 3.2 I'd like to get into a release. Maybe we can cut from there?

Sounds good. master got so many changes, including two backward incompatible ones. We could do a patch release with your commit. What is its SHA?

@tute
Copy link
Contributor Author

tute commented Sep 6, 2015

I think we are planning on dropping support for 3.2 as apart of that release?

Yes.

Should we hold off on releasing this until Rails 5 lands

We could hold off the backwards incompatible changes, but a minor version with everything else would be healthy I think. Let's ask @jyurek!

@jyurek
Copy link

jyurek commented Sep 8, 2015

I think a minor version without the backwards incompatible changes are probably best right now, and we can discuss things like the MD5->SHA change.

@iwz
Copy link

iwz commented Sep 8, 2015

@tute the SHA I'm looking for is c740fb1

@tute
Copy link
Contributor Author

tute commented Sep 9, 2015

After we release #1995, I'll merge master into it, and rebase this branch when we decide it's time to do the major release. Thank you for your input.

@tute tute added this to the v5.0.0 milestone Sep 10, 2015
@detournemint
Copy link

It seems like #1995 was merged in, what's the status on this?

@tute
Copy link
Contributor Author

tute commented Oct 20, 2015

We'll release the major version after Rails 5 is out. The commit that fixed a Rails 3.2 regression is already out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants