fix(Stub): align #destroyed with #new_record/#persisted #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
force-pushed
the
align_destroyed_stub_with_active_record
branch
from
47d425a to
82d737a
Compare
mike-burns
force-pushed
the
align_destroyed_stub_with_active_record
branch
from
82d737a to
6486fce
Compare
|
Thanks for aligning it with ActiveRecord! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised to find that #destroyed? returns nil
instead of false when I build_stubbed. I don't see
a reason for it in the commit history nor in Rails,
so I thought it was fair game for this PR.