Tidy up and add yarn to bin/setup #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we weren't including yarn, likely from back when we didn't need it. This was also a good opportunity to remove the comments, simplify and modernise some of the commands we run (by running commands through `bin/rails`).
nickcharlton
added
documentation
nickcharlton
added a commit
that referenced
this pull request
Jan 10, 2025
In #2748, we tidied up some parts of `bin/setup`, but went too far and also remove the `bundle install` command. Once we made a change to bundle, this then failed. So add that back in.
nickcharlton
added a commit
that referenced
this pull request
Jan 10, 2025
In #2748, we tidied up some parts of `bin/setup`, but went too far and also remove the `bundle install` command. Once we made a change to bundle, this then failed. So add that back in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we weren't including yarn, likely from back when we didn't need it.
This was also a good opportunity to remove the comments, simplify and modernise some of the commands we run (by running commands through
bin/rails).