Switch to Puma for Rack compatibility #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're now using Rack 3, since upgrading to Rails 8.0 in #2705. There's an incompatiblity between Unicorn and Rack 3, which whilst it has a commit to fix it, hasn't been released yet. Unfortunately it wasn't possible to bundle Unicorn directly from the repo, and building the gem locally didn't work despite a few attempts. Instead, let's switch to Puma. Fixes #2730. https://stackoverflow.com/a/78594913 https://yhbt.net/unicorn.git/9d7bab0bc2211b20806d4d0289a7ea992e49a8a1/s/
|
There's no easy way to test compatibility with older Rails versions, and this is something that should only affect the demo app and documentation, so I'm not that concerned about it. It's running now on Heroku for the prerelease and seems to be working acceptably. |
nickcharlton
added
documentation
slickepinne
added a commit
that referenced
this pull request
Jan 9, 2025
In #2744, we moved away from Unicorn and switched to puma. While Procfile got updated, Procfile.dev did not.
Merged
nickcharlton
pushed a commit
that referenced
this pull request
Jan 9, 2025
In #2744, we moved away from Unicorn and switched to puma. While Procfile got updated, Procfile.dev did not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now using Rack 3, since upgrading to Rails 8.0 in #2705. There's an incompatiblity between Unicorn and Rack 3, which whilst it has a commit to fix it, hasn't been released yet.
Unfortunately it wasn't possible to bundle Unicorn directly from the repo, and building the gem locally didn't work despite a few attempts.
Instead, let's switch to Puma.
Fixes #2730.
https://stackoverflow.com/a/78594913
https://yhbt.net/unicorn.git/9d7bab0bc2211b20806d4d0289a7ea992e49a8a1/s/