Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate fields/rich_text/form with documentation #2693

Merged
merged 1 commit into from
Nov 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions app/views/fields/rich_text/_form.html.erb
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
<%#
# Rich Text Form Partial

This partial renders a trix-editor element for ActionText::RichText attributes.

## Local variables:

- `f`:
A Rails form generator, used to help create the appropriate trix-editor fields.
- `field`:
An instance of [Administrate::Field::RichText][1].
A wrapper around the tmie attributes pulled from the model.

[1]: http://www.rubydoc.info/gems/administrate/Administrate/Field/RichText
%>

<div class="field-unit__label">
<%= f.label field.attribute %>
</div>
Expand Down
37 changes: 12 additions & 25 deletions spec/administrate/views/fields/rich_text/_form_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,37 +17,24 @@ def main_app
"ProductDashbard::ATTRIBUTE_TYPES",
banner: Administrate::Field::RichText
)
product = build(:product, name: nil)
product = build(:product, banner: "<div>Rich text</div>")
banner = instance_double(
"Administrate::Field::RichText",
attribute: :banner,
data: nil
data: product.banner
)

render(
partial: "fields/rich_text/form",
locals: {field: banner, f: form_builder(product)}
)
fields model: product do |f|
render(
partial: "fields/rich_text/form",
locals: {field: banner, f: f}
)
end

expect(rendered).to have_field(
"product_banner_trix_input_product", type: "hidden"
)
end

def form_builder(object)
ActionView::Helpers::FormBuilder.new(
object.model_name.singular,
object,
build_template,
{}
)
end

def build_template
Object.new.tap do |template|
template.extend ActionView::Helpers::FormHelper
template.extend ActionView::Helpers::FormOptionsHelper
template.extend ActionView::Helpers::FormTagHelper
end
"trix_input_product", type: "hidden", with: product.banner.body.to_trix_html
).and(have_element(
"trix-editor", input: "trix_input_product"
))
end
end
37 changes: 12 additions & 25 deletions spec/administrate/views/fields/select/_edit_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@
html_controller: "select"
)

render(
partial: "fields/select/form",
locals: {field: select, f: form_builder(customer)}
)
fields model: customer do |f|
render(
partial: "fields/select/form",
locals: {field: select, f: f}
)
end

expect(rendered).to have_css(
%(select[name="customer[email_subscriber]"][data-controller~=select]
Expand All @@ -35,31 +37,16 @@
html_controller: "select"
)

render(
partial: "fields/select/form",
locals: {field: select, f: form_builder(customer)}
)
fields model: customer do |f|
render(
partial: "fields/select/form",
locals: {field: select, f: f}
)
end

expect(rendered).to have_css(
%(select[name="customer[email_subscriber]"][data-controller~="select"] option[value=""]),
text: "Unknown"
)
end

def form_builder(object)
ActionView::Helpers::FormBuilder.new(
object.model_name.singular,
object,
build_template,
{}
)
end

def build_template
Object.new.tap do |template|
template.extend ActionView::Helpers::FormHelper
template.extend ActionView::Helpers::FormOptionsHelper
template.extend ActionView::Helpers::FormTagHelper
end
end
end
25 changes: 5 additions & 20 deletions spec/administrate/views/fields/text/_form_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,26 +31,11 @@
def render_partial(field)
product = build(:product)

render(
partial: "fields/text/form",
locals: {field: field, f: form_builder(product)}
)
end

def form_builder(object)
ActionView::Helpers::FormBuilder.new(
object.model_name.singular,
object,
build_template,
{}
)
end

def build_template
Object.new.tap do |template|
template.extend ActionView::Helpers::FormHelper
template.extend ActionView::Helpers::FormOptionsHelper
template.extend ActionView::Helpers::FormTagHelper
fields model: product do |f|
render(
partial: "fields/text/form",
locals: {field: field, f: f}
)
end
end
end
27 changes: 6 additions & 21 deletions spec/administrate/views/fields/url/_form_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,28 +10,13 @@
data: nil
)

render(
partial: "fields/url/form",
locals: {field: url, f: form_builder(product)}
)
fields model: product do |f|
render(
partial: "fields/url/form",
locals: {field: url, f: f}
)
end

expect(rendered).to have_css(%(input[type="url"][name="product[image_url]"]))
end

def form_builder(object)
ActionView::Helpers::FormBuilder.new(
object.model_name.singular,
object,
build_template,
{}
)
end

def build_template
Object.new.tap do |template|
template.extend ActionView::Helpers::FormHelper
template.extend ActionView::Helpers::FormOptionsHelper
template.extend ActionView::Helpers::FormTagHelper
end
end
end
Loading