Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout first to avoid failure due to ChromeDriver file in target dir #2316

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

pablobm
Copy link
Collaborator

@pablobm pablobm commented Jan 26, 2023

CI started breaking on 11 Jan for no good reason. After some research, it appears that the step to download ChromeDriver now leaves an artefact in the working directory: a license file LICENSE.chromedriver. When Git sees it, it refuses to checkout the code, as the target directory is neither empty nor a Git repository.

To fix this, I have moved the checkout step to run first, before ChromeDriver is downloaded.

Note that the build will still fail due to the bundle audit. After this is merged, I should be able to merge the dependabot PRs and fix that.

Specifically, it says this at the checkout step:

> Directory (/home/circleci/administrate) you are trying to checkout to
> is not empty and not a git repository
The download of ChromeDriver leaves a file `LICENSE.chromedriver`, which
breaks the checkout. Git fails with the following message:

> Directory (/home/circleci/administrate) you are trying to checkout
> to is not empty and not a git repository
@pablobm pablobm marked this pull request as ready for review January 26, 2023 14:59
@pablobm pablobm changed the title Trying to fix CI (part deux) Checkout first to avoid failure due to ChromeDriver file in target dir Jan 26, 2023
@pablobm pablobm merged commit cf7c909 into main Jan 26, 2023
@pablobm pablobm deleted the fix-ci branch January 26, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant