More natural tabbing across rows in table #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user presses tab, the browser is expected to move to the next link. Since all cells in the table are links, the user is expected to press many times (once per column) in order to move to the next row. Since each row works as a link, so much tabbing should not be necessary. This change makes it so that each row is tabbable, but not the cells. An exception is if the data in the cell is internally represented as a link. This is the case of email fields. In this case, this data link is still accessible with an additional tab press for each row: the row will be highlighted first, then each data link.
nickcharlton
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR is a split from #1494, which was mixing two different concerns.)
When the user presses tab, the browser is expected to move to the next link. Since all cells in the table are links, the user has to press tab many times (once per column) in order to move to the next row:
Since each row works as a link, so much tabbing should not be necessary. This change makes it so that each row is tabbable, but not the cells.
There are two exceptions: action links, and data that should actually be represented as a link (eg: instances of
Field::UrlorField::Email). These are not affected by this change, and are still accessible with an additional tab press for each cell. The row will be highlighted first, then each data link: