Only define Punditize if Pundit has been loaded. #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `RAILS_ENV` is set to `production`, the concern will be eagerly loaded. As we `include Pundit` here, this means that it'll fail if `pundit` isn't included in the bundle. Fixes #1048.
|
Oops! Good spot! The fix looks good to me! |
fbuys
added a commit
to fbuys/administrate
that referenced
this pull request
May 23, 2023
This commit fixes: thoughtbot#2378 By adding a conditional that includes Pundit::Authorization when it is defined else it includes Pundit. This change ensures that we remain compatible with Pundit < 2.2.0 See: thoughtbot#2141 See: thoughtbot#1068
fbuys
added a commit
to fbuys/administrate
that referenced
this pull request
May 23, 2023
This commit fixes: thoughtbot#2378 By adding a conditional that includes Pundit::Authorization when it is defined else it includes Pundit. This change ensures that we remain compatible with Pundit < 2.2.0 To test with Pundit "~> 2.1.0", we run: ``` bundle exec appraisal pundit21 rspec spec/controllers/concerns/administrate/punditize_spec.rb ``` See: thoughtbot#2141 See: thoughtbot#1068
fbuys
added a commit
to fbuys/administrate
that referenced
this pull request
May 23, 2023
This commit fixes: thoughtbot#2378 By adding a conditional that includes Pundit::Authorization when it is defined else it includes Pundit. This change ensures that we remain compatible with Pundit < 2.2.0 To test with Pundit "~> 2.1.0", we run: ``` bundle exec appraisal pundit21 rspec spec/controllers/concerns/administrate/punditize_spec.rb ``` See: thoughtbot#2141 See: thoughtbot#1068
fbuys
added a commit
to fbuys/administrate
that referenced
this pull request
May 24, 2023
This commit fixes: thoughtbot#2378 By adding a conditional that includes Pundit::Authorization when it is defined else it includes Pundit. This change ensures that we remain compatible with Pundit < 2.2.0 To test with Pundit "~> 2.1.0", we run: ``` bundle exec appraisal pundit21 rspec spec/controllers/concerns/administrate/punditize_spec.rb ``` See: thoughtbot#2141 See: thoughtbot#1068
fbuys
added a commit
to fbuys/administrate
that referenced
this pull request
May 26, 2023
This commit fixes: thoughtbot#2378 By adding a conditional that includes Pundit::Authorization when it is defined else it includes Pundit. This change ensures that we remain compatible with Pundit < 2.2.0 To test with Pundit "~> 2.1.0", we run: ``` bundle exec appraisal pundit21 rspec spec/controllers/concerns/administrate/punditize_spec.rb ``` See: thoughtbot#2141 See: thoughtbot#1068
pablobm
pushed a commit
that referenced
this pull request
May 27, 2023
This commit fixes #2378 by adding a conditional that includes Pundit::Authorization when it is defined else it includes Pundit. This change ensures that we remain compatible with Pundit < 2.2.0 To test with Pundit "~> 2.1.0", we run: ``` bundle exec appraisal pundit21 rspec spec/controllers/concerns/administrate/punditize_spec.rb ``` See: #2141 See: #1068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
RAILS_ENVis set toproduction, the concern will be eagerlyloaded. As we
include Pundithere, this means that it'll fail ifpunditisn't included in the bundle.Fixes #1048.