Proposal: don't rely on JS for this

thoughtbot · Jun 25, 2020 · 4139752 · 4139752
1 parent 5071abb
commit 4139752
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/spec/features/log_entries_index_spec.rb b/spec/features/log_entries_index_spec.rb
@@ -49,11 +49,18 @@
   end
 
   scenario "user deletes record" do
-    create(:log_entry)
+    log_entry = create(:log_entry)
 
     visit admin_log_entries_path
     click_on t("administrate.actions.destroy")
+    expect(page).to have_text(
+      t(
+        "administrate.actions.destroy_resource",
+        name: LogEntryDashboard.new.display_resource(log_entry),
+      ),
+    )
 
+    click_on t("administrate.actions.destroy")
     expect(page).to have_flash(
       t("administrate.controller.destroy.success", resource: "LogEntry"),
     )

diff --git a/spec/features/orders_index_spec.rb b/spec/features/orders_index_spec.rb
@@ -46,13 +46,20 @@
   end
 
   scenario "user deletes record" do
-    create(:order)
+    order = create(:order)
 
     visit admin_orders_path
     click_on t("administrate.actions.destroy")
+    expect(page).to have_text(
+      t(
+        "administrate.actions.destroy_resource",
+        name: OrderDashboard.new.display_resource(order),
+      ),
+    )
 
+    click_on t("administrate.actions.destroy")
     expect(page).to have_flash(
-      t("administrate.controller.destroy.success", resource: "Order")
+      t("administrate.controller.destroy.success", resource: "Order"),
     )
   end
 
@@ -61,7 +68,7 @@
 
     visit admin_orders_path
     click_on t("administrate.actions.destroy")
-
+    click_on t("administrate.actions.destroy")
     expect(page).to have_flash(
       "Cannot delete record because dependent payments exist", type: :error
     )