Make subinclude take annotated label and list #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why it fails on darwin, any clues? @Tatskaari |
izissise
force-pushed
the
subinclude-namedout
branch
from
656e7f9 to
9bbeb69
Compare
|
I guess it was just an intermittent bug, relaunching the CI worked |
|
@peterebden Hello, is it something please team doesn't want? |
No, sorry, definitely desirable to support annotated labels here. The team is just under a lot of pressure right now, and I think this slipped under our radar. |
Tatskaari
approved these changes
Jan 29, 2024
izissise
added a commit
to Wuageorg/please
that referenced
this pull request
Feb 18, 2024
samwestmoreland
pushed a commit
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to subinclude a target named output
Fix #2939