Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set remote url empty for all profiles except remote ones #2984

Merged
merged 3 commits into from
Nov 30, 2023
Merged

set remote url empty for all profiles except remote ones #2984

merged 3 commits into from
Nov 30, 2023

Conversation

goddenrich
Copy link
Contributor

@goddenrich goddenrich commented Nov 29, 2023 •
edited
Loading

setting the plzconfig so we don't use remote execution to build this even if set on the system level. Also setting the value in all e2e tests

@Tatskaari
Copy link
Member

Why do we need this in all the profiles? Isn't just .plzconfig enough?

@goddenrich
Copy link
Contributor Author

Why do we need this in all the profiles? Isn't just .plzconfig enough?

The tests use remote execution if not

@goddenrich goddenrich requested a review from Tatskaari November 30, 2023 14:42
@goddenrich goddenrich merged commit 825ef4c into thought-machine:master Nov 30, 2023
5 checks passed
@goddenrich goddenrich deleted the set-empty-remote-url branch April 25, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwestmoreland samwestmoreland samwestmoreland approved these changes

@Tatskaari Tatskaari Awaiting requested review from Tatskaari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goddenrich @Tatskaari @samwestmoreland