-
Notifications
You must be signed in to change notification settings - Fork 129
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #519 from b0ink/docs/migrate/comments-modal
docs: comments-modal migration component review
- Loading branch information
Showing
5 changed files
with
44 additions
and
0 deletions.
There are no files selected for viewing
Binary file added
BIN
+700 KB
...ck/UI Enhancement/Component Reviews/Resources/comments-modal-image-migrated.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+651 KB
...ck/UI Enhancement/Component Reviews/Resources/comments-modal-image-original.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+653 KB
...rack/UI Enhancement/Component Reviews/Resources/comments-modal-pdf-migrated.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+613 KB
...rack/UI Enhancement/Component Reviews/Resources/comments-modal-pdf-original.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
44 changes: 44 additions & 0 deletions
44
docs/OnTrack/UI Enhancement/Component Reviews/comments-modal.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# Ontrack Component review | ||
|
||
## Team Member Name | ||
|
||
Eliya G | s222313935 | ||
|
||
## Component Name | ||
|
||
- `comments-modal.coffee` | ||
- `comments-modal.tpl.html` | ||
- `comments-modal.scss` | ||
|
||
## Component purpose | ||
|
||
The purpose of `comments-modal` is to display images and PDFs from task comments as a fullscreen | ||
modal popup, allowing users to view the content without having to download or open it in another | ||
tab. | ||
|
||
## Component outcomes and interactions | ||
|
||
Users can click on the image or `view PDF` comment on task which triggers `comments-modal` to popup | ||
with the enlarged image, or an embedded PDF. `comments-modal` accepts two objects: | ||
|
||
```typescript | ||
@Input() commentType: string; // either 'image' or 'pdf' | ||
@Input() commentResourceUrl: string; // the url to the image or pdf | ||
``` | ||
|
||
## Component migration plan | ||
|
||
I will be following | ||
[doubtfire-web's Migration Guide](https://github.com/thoth-tech/doubtfire-web/blob/e70f4c7cd1395eaab942ee389788f75f92e985c9/MIGRATION-GUIDE.md) | ||
and refer to existing components already migrated to TypeScript to ensure my code follows the same | ||
code style & conventions. | ||
|
||
Original (Image):  | ||
|
||
Original (PDF):  | ||
|
||
## Component Post-Migration | ||
|
||
Migrated (Image):  | ||
|
||
Migrated (PDF):  |