Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messaging v0.8 #185

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Messaging v0.8 #185

merged 3 commits into from
Jan 18, 2021

Conversation

KPostOffice
Copy link
Member

Related Issues and Dependencies

Update to use messaging > 0.8

This introduces a breaking change

  • Yes
  • No

Change env variables in thoth-application template

This Pull Request implements

No longer using Faust for messaging

@KPostOffice KPostOffice requested a review from fridex as a code owner January 15, 2021 18:58
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 15, 2021
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks! 💯

@sesheta
Copy link
Member

sesheta commented Jan 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2021
@sesheta sesheta merged commit e9b3e35 into thoth-station:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants