Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize metrics for revision check #434

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

pacospace
Copy link
Contributor

Signed-off-by: Francesco Murdaca [email protected]

Related Issues and Dependencies

Related-To: thoth-station/metrics-exporter#529
Related-to: thoth-station/metrics-exporter#577

Standardize metric for schema check introducing filter by deployment name, so that metrics-exporter can handle correct metrics.

Signed-off-by: Francesco Murdaca <[email protected]>
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 25, 2021
@pacospace pacospace requested review from KPostOffice and fridex and removed request for saisankargochhayat and harshad16 January 25, 2021 08:42
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@sesheta
Copy link
Member

sesheta commented Jan 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2021
@harshad16
Copy link
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants