-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a pipeline unit for selective pre-release filtering #1648
Conversation
/hold ...wait for thoth-python release and I'll write some docs. |
c9dbb34
to
712c9ca
Compare
Pytest Test failed! Click here
|
712c9ca
to
b9e8b43
Compare
/unhold Docs in #1650, thoth-python update already landed. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related Issues and Dependencies
Depends-On: thoth-station/python#334
Related: thoth-station/thoth-application#816
Related: pypa/pipenv#4607
This introduces a breaking change
This Pull Request implements
With this change, we will provide experimental support for allowing pre-releases only for selected packages, based on configuration in Pipfile. Users can state which dependencies can be included in a form of pre-releases. An example could be the following Pipfile:
As stated in the configuration, resolver will include pre-releases only for matching TensorFlow=>2.3. As pre-releases apply only for TensorFlow itself, all the other packages will need to be released (not in a form of a pre-release). This configuration option is applicable to any dependencies in the dependency graph, not just for the direct ones.
As this feature is not supported by the Python community, we require custom configuration options in Pipfile which diverge from the upstream. Users should be aware that.