Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use testify everywhere #80

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Use testify everywhere #80

merged 1 commit into from
Apr 1, 2021

Conversation

thomaspoignant
Copy link
Owner

Description

Some tests were not using testify, this PR tries to have the same test strategy everywhere.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-compatible and/or changes current functionality)

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the Readme
  • I have followed the contributing guide

@thomaspoignant thomaspoignant self-assigned this Apr 1, 2021
@thomaspoignant thomaspoignant added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Apr 1, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thomaspoignant thomaspoignant merged commit c493ecc into main Apr 1, 2021
@thomaspoignant thomaspoignant deleted the feat/improve-tests branch April 1, 2021 12:22
thomaspoignant added a commit that referenced this pull request Oct 11, 2021
@thomaspoignant
Use testify everywhere (#80)
b26fcc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomaspoignant thomaspoignant

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thomaspoignant