Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a race condition that can be rarely detected while running tests #78

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Fix a race condition that can be rarely detected while running tests #78

merged 2 commits into from
Apr 1, 2021

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Apr 1, 2021 •
edited
Loading

Description

Sometimes when running the tests we detect a race condition in the cache.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-comptible and/or changes current functionality)

Closes issue(s)

Resolve #79

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the Readme
  • I have followed the contributing guide

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thomaspoignant thomaspoignant added the bug Something isn't working label Apr 1, 2021
@thomaspoignant thomaspoignant merged commit b914fa3 into main Apr 1, 2021
@thomaspoignant thomaspoignant deleted the fix/race-condition branch April 1, 2021 12:21
@thomaspoignant thomaspoignant self-assigned this Apr 1, 2021
thomaspoignant added a commit that referenced this pull request Oct 11, 2021
@thomaspoignant
Fix a race condition that can be rarely detected while running tests (#…
a3bce5c 
…78)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomaspoignant thomaspoignant

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(bug) Race condition during tests
1 participant
@thomaspoignant