Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to avoid global variable as much as possible #55

Merged
merged 7 commits into from
Jan 18, 2021
Merged

Refactor to avoid global variable as much as possible #55

merged 7 commits into from
Jan 18, 2021

Conversation

thomaspoignant
Copy link
Owner

Description

Refactoring of the code to avoid as much as possible the usage of global variables.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-comptible and/or changes current functionality)

Closes issue(s)

Resolve #52

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the Readme
  • I have followed the contributing guide

@thomaspoignant thomaspoignant marked this pull request as draft January 15, 2021 11:04
@thomaspoignant thomaspoignant marked this pull request as ready for review January 15, 2021 17:50
@thomaspoignant thomaspoignant self-assigned this Jan 15, 2021
@thomaspoignant thomaspoignant added the enhancement New feature or request label Jan 15, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thomaspoignant thomaspoignant merged commit 26c25bd into main Jan 18, 2021
@thomaspoignant thomaspoignant deleted the remove-global-variable branch January 18, 2021 08:46
thomaspoignant added a commit that referenced this pull request Oct 11, 2021
@thomaspoignant
Refactor to avoid global variable as much as possible (#55)
2c7b745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomaspoignant thomaspoignant

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(change) Don't use package global variable
1 participant
@thomaspoignant