Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log flag changes #53

Merged
merged 8 commits into from
Jan 14, 2021
Merged

Log flag changes #53

merged 8 commits into from
Jan 14, 2021

Conversation

thomaspoignant
Copy link
Owner

Description

If you provide a logger in the config, your flag changes will be logs to help you to understand what has changed.
There are different logs available depending on what has changed.

[2021-01-14T11:53:38+01:00] flag add-test-flag added
[2021-01-14T11:53:38+01:00] flag test-flag removed
[2021-01-14T11:53:38+01:00] flag test-flag is turned OFF
[2021-01-14T11:53:38+01:00] flag test-flag is turned ON (flag=[percentage=100%, rule="key eq "random-key"", true="true", false="false", true="false", disable="false"])  
[2021-01-14T11:53:38+01:00] flag test-flag updated, old=[percentage=100%, rule="key eq "random-key"", true="true", false="false", true="false", disable="false"], new=[percentage=100%, true="true", false="false", true="false", disable="false"]

Changes include

  • Bugfix (a non-breaking change that solves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking changes (a change that is not backward-compatible and/or changes current functionality)

Closes issue(s)

Resolve #18

Checklist

  • I have tested this code
  • I have added a unit tests to cover this code
  • I have updated the Readme
  • I have followed the contributing guide

@thomaspoignant thomaspoignant added the enhancement New feature or request label Jan 14, 2021
@thomaspoignant thomaspoignant self-assigned this Jan 14, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thomaspoignant thomaspoignant merged commit 34e3d1a into main Jan 14, 2021
@thomaspoignant thomaspoignant deleted the feature/log-flag-changes branch January 14, 2021 11:11
thomaspoignant added a commit that referenced this pull request Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature) Log flag changes
1 participant