Force to use only one retriever at the time #49
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I change the way to pass the
Retriever
in the config.We don't have a property for each type of Retriever but only on
Retriever
which can manage all types of Retriever.Why?
The main reason is to have the
aws/aws-sdk-go
as a dependency only if you are using theS3Retriever
. With this new syntax, we don't force you to have the SDK if you are not using it.How to migrate
If you were using
HTTPRetriever
,S3Retriever
orGithubRetriever
, the change consists only of changing the key in the config.It is a bit different for the flag configuration, I have introduced a
FileRetriever
to keep the same format for all retrievers.Changes include
Closes issue(s)
Resolve #42
Checklist