Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more variations for a flag #363

Merged
merged 60 commits into from
Oct 12, 2022
Merged

Allow more variations for a flag #363

Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
4d48849
Introducing the new InternalFlag and all the associated behaviors
thomaspoignant Jul 28, 2022
309335c
Fix test bug
thomaspoignant Jul 28, 2022
18fb288
Using new struct with legacy syntax
thomaspoignant Jul 29, 2022
84f729f
Remove nil field
thomaspoignant Jul 29, 2022
16e0312
Remove unused test files
thomaspoignant Jul 29, 2022
0679472
Unused util function
thomaspoignant Jul 29, 2022
9118f83
Remove println
thomaspoignant Jul 29, 2022
a229b13
Remove flag_data from variation test
thomaspoignant Jul 29, 2022
ae0b313
Remove usage of flagv1.FlagData
thomaspoignant Jul 29, 2022
cd84bf9
continue to remove flagv1
thomaspoignant Jul 29, 2022
5e158d2
Remove usage of flagv1 package
thomaspoignant Jul 29, 2022
386c299
Order for constitency
thomaspoignant Jul 29, 2022
c0a2c02
Merge remote-tracking branch 'origin/main' into more-variant
thomaspoignant Aug 1, 2022
6a46813
Remove flagv1 package
thomaspoignant Aug 1, 2022
942d2d7
Merge remote-tracking branch 'origin/main' into more-variant
thomaspoignant Aug 1, 2022
1514d89
Disable schedule step in schedule step
thomaspoignant Aug 1, 2022
988870e
Add test to ensure we cannot have scheduled step with scheduled steps
thomaspoignant Aug 1, 2022
12f0c21
converter tests
thomaspoignant Aug 1, 2022
ec35950
Add comments
thomaspoignant Aug 1, 2022
08f46c1
WIP
thomaspoignant Aug 3, 2022
145df10
WIP
thomaspoignant Aug 7, 2022
db81cf2
WIP
thomaspoignant Aug 7, 2022
f62e565
Rework the convert layer
thomaspoignant Aug 7, 2022
0507b01
Merge remote-tracking branch 'origin/main' into more-variant
thomaspoignant Aug 7, 2022
429141e
adding field
thomaspoignant Aug 7, 2022
d394e84
remove method string from the flag contract
thomaspoignant Aug 7, 2022
48d0187
Adding more test for internal flag
thomaspoignant Aug 8, 2022
cb85346
Stop using DTOv0 directly
thomaspoignant Aug 8, 2022
f2e1a4b
Manage to unmarshal multiple fields with same name
thomaspoignant Aug 8, 2022
6b1319b
wrong file
thomaspoignant Aug 8, 2022
66c2fd6
Rename cli
thomaspoignant Aug 8, 2022
4f36f99
add doc
thomaspoignant Aug 8, 2022
e949a88
Remove usage of ioutil
thomaspoignant Aug 8, 2022
724f074
Add godoc
thomaspoignant Aug 9, 2022
5dfc143
Change TOML lib to use BurntSushi/toml
thomaspoignant Aug 9, 2022
f4053ea
Merge branch 'main' into more-variant
thomaspoignant Aug 9, 2022
61968c9
Add test for new flag format
thomaspoignant Aug 9, 2022
1473330
Merge branch 'main' into more-variant
thomaspoignant Aug 9, 2022
d45b63e
Merge branch 'main' into more-variant
thomaspoignant Sep 9, 2022
54e7301
Bump github.com/google/go-cmp from 0.5.8 to 0.5.9 (#335)
dependabot[bot] Sep 9, 2022
f0964c8
Bump github.com/aws/aws-sdk-go from 1.44.93 to 1.44.94 (#336)
dependabot[bot] Sep 9, 2022
42abbde
Add a validation for the flag to avoid to have invalid flag in the cache
thomaspoignant Sep 26, 2022
9e8dbf6
Merge remote-tracking branch 'origin/main' into more-variant
thomaspoignant Sep 26, 2022
c72254c
Move the rollout options to the top level of the flag
thomaspoignant Sep 29, 2022
3db50b5
Merge remote-tracking branch 'origin/main' into more-variant
thomaspoignant Sep 29, 2022
c3f782d
update doc
thomaspoignant Oct 4, 2022
a6e3c70
Move rollout on top level
thomaspoignant Oct 4, 2022
b3272b8
migration cli binary
thomaspoignant Oct 5, 2022
d93e91e
Merge branch 'main' into more-variant
thomaspoignant Oct 5, 2022
0573fd0
Modify flagv1 for compatibility
thomaspoignant Oct 5, 2022
65c24b4
Merge branch 'main' into more-variant
thomaspoignant Oct 10, 2022
8180392
fix doc
thomaspoignant Oct 12, 2022
298511e
Bump go version CI
thomaspoignant Oct 12, 2022
f3d14d7
Fix antlr dependencies
thomaspoignant Oct 12, 2022
4a50755
Add test for convertion cli
thomaspoignant Oct 12, 2022
ec3a805
improve makefile
thomaspoignant Oct 12, 2022
dc229d4
remove unused function
thomaspoignant Oct 12, 2022
e4d8f4f
remove Print
thomaspoignant Oct 12, 2022
82951a2
remove header for v1
thomaspoignant Oct 12, 2022
51f7ad7
Format the files
thomaspoignant Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Unused util function 
Signed-off-by: Thomas Poignant <[email protected]>
  • Loading branch information
@thomaspoignant
thomaspoignant committed Jul 29, 2022
commit 0679472c52eba9fc491574f8a9cd12179559b398
12 changes: 0 additions & 12 deletions internal/utils/stringAppender.go
View file
Open in desktop

This file was deleted.