Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when calling variation before initialisation #361

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Fix error when calling variation before initialisation #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 53 additions & 6 deletions variation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,15 @@ const (
errorWrongVariation = "wrong variation used for flag %v"
)

var offlineVariationResult = model.VariationResult{VariationType: flag.VariationSDKDefault, Failed: true}
var (
offlineVariationResult = model.VariationResult{VariationType: flag.VariationSDKDefault, Failed: false}
notInitVariationResult = model.VariationResult{
VariationType: flag.VariationSDKDefault,
Failed: true,
Reason: flag.ReasonError,
ErrorCode: flag.ErrorCodeProviderNotReady,
}
)

// BoolVariation return the value of the flag in boolean.
// An error is return if you don't have init the library before calling the function.
Expand Down Expand Up @@ -143,6 +151,10 @@ func (g *GoFeatureFlag) JSONVariation(
// AllFlagsState return a flagstate.AllFlags that contains all the flags for a specific user.
func (g *GoFeatureFlag) AllFlagsState(user ffuser.User) flagstate.AllFlags {
flags := map[string]flag.Flag{}
if g == nil {
// empty AllFlags will set valid to false
return flagstate.AllFlags{}
}

if !g.config.Offline {
var err error
Expand Down Expand Up @@ -211,9 +223,14 @@ func (g *GoFeatureFlag) GetFlagsFromCache() (map[string]flag.Flag, error) {
}

// boolVariation is the internal func that handle the logic of a variation with a bool value
// the result will always contains a valid model.BoolVarResult
// the result will always contain a valid model.BoolVarResult
func (g *GoFeatureFlag) boolVariation(flagKey string, user ffuser.User, sdkDefaultValue bool,
) (model.BoolVarResult, error) {
if g == nil {
return model.BoolVarResult{Value: sdkDefaultValue, VariationResult: notInitVariationResult},
fmt.Errorf("go-feature-flag is not initialised, default value is used")
}

if g.config.Offline {
return model.BoolVarResult{Value: sdkDefaultValue, VariationResult: offlineVariationResult}, nil
}
Expand Down Expand Up @@ -254,6 +271,11 @@ func (g *GoFeatureFlag) boolVariation(flagKey string, user ffuser.User, sdkDefau
// the result will always contain a valid model.IntVarResult
func (g *GoFeatureFlag) intVariation(flagKey string, user ffuser.User, sdkDefaultValue int,
) (model.IntVarResult, error) {
if g == nil {
return model.IntVarResult{Value: sdkDefaultValue, VariationResult: notInitVariationResult},
fmt.Errorf("go-feature-flag is not initialised, default value is used")
}

if g.config.Offline {
return model.IntVarResult{Value: sdkDefaultValue, VariationResult: offlineVariationResult}, nil
}
Expand Down Expand Up @@ -298,9 +320,14 @@ func (g *GoFeatureFlag) intVariation(flagKey string, user ffuser.User, sdkDefaul
}

// float64Variation is the internal func that handle the logic of a variation with a float64 value
// the result will always contains a valid model.Float64VarResult
// the result will always contain a valid model.Float64VarResult
func (g *GoFeatureFlag) float64Variation(flagKey string, user ffuser.User, sdkDefaultValue float64,
) (model.Float64VarResult, error) {
if g == nil {
return model.Float64VarResult{Value: sdkDefaultValue, VariationResult: notInitVariationResult},
fmt.Errorf("go-feature-flag is not initialised, default value is used")
}

if g.config.Offline {
return model.Float64VarResult{Value: sdkDefaultValue, VariationResult: offlineVariationResult}, nil
}
Expand Down Expand Up @@ -337,9 +364,14 @@ func (g *GoFeatureFlag) float64Variation(flagKey string, user ffuser.User, sdkDe
}

// stringVariation is the internal func that handle the logic of a variation with a string value
// the result will always contains a valid model.StringVarResult
// the result will always contain a valid model.StringVarResult
func (g *GoFeatureFlag) stringVariation(flagKey string, user ffuser.User, sdkDefaultValue string,
) (model.StringVarResult, error) {
if g == nil {
return model.StringVarResult{Value: sdkDefaultValue, VariationResult: notInitVariationResult},
fmt.Errorf("go-feature-flag is not initialised, default value is used")
}

if g.config.Offline {
return model.StringVarResult{Value: sdkDefaultValue, VariationResult: offlineVariationResult}, nil
}
Expand Down Expand Up @@ -376,9 +408,14 @@ func (g *GoFeatureFlag) stringVariation(flagKey string, user ffuser.User, sdkDef
}

// jsonArrayVariation is the internal func that handle the logic of a variation with a json value
// the result will always contains a valid model.JSONArrayVarResult
// the result will always contain a valid model.JSONArrayVarResult
func (g *GoFeatureFlag) jsonArrayVariation(flagKey string, user ffuser.User, sdkDefaultValue []interface{},
) (model.JSONArrayVarResult, error) {
if g == nil {
return model.JSONArrayVarResult{Value: sdkDefaultValue, VariationResult: notInitVariationResult},
fmt.Errorf("go-feature-flag is not initialised, default value is used")
}

if g.config.Offline {
return model.JSONArrayVarResult{Value: sdkDefaultValue, VariationResult: offlineVariationResult}, nil
}
Expand Down Expand Up @@ -415,9 +452,14 @@ func (g *GoFeatureFlag) jsonArrayVariation(flagKey string, user ffuser.User, sdk
}

// jsonVariation is the internal func that handle the logic of a variation with a json value
// the result will always contains a valid model.JSONVarResult
// the result will always contain a valid model.JSONVarResult
func (g *GoFeatureFlag) jsonVariation(flagKey string, user ffuser.User, sdkDefaultValue map[string]interface{},
) (model.JSONVarResult, error) {
if g == nil {
return model.JSONVarResult{Value: sdkDefaultValue, VariationResult: notInitVariationResult},
fmt.Errorf("go-feature-flag is not initialised, default value is used")
}

if g.config.Offline {
return model.JSONVarResult{Value: sdkDefaultValue, VariationResult: offlineVariationResult}, nil
}
Expand Down Expand Up @@ -477,6 +519,11 @@ func computeVariationResult(flag flag.Flag, resolutionDetails flag.ResolutionDet
// Note: Use this function only if you are using multiple go-feature-flag instances.
func (g *GoFeatureFlag) RawVariation(flagKey string, user ffuser.User, sdkDefaultValue interface{},
) (model.RawVarResult, error) {
if g == nil {
return model.RawVarResult{Value: sdkDefaultValue, VariationResult: notInitVariationResult},
fmt.Errorf("go-feature-flag is not initialised, default value is used")
}

if g.config.Offline {
return model.RawVarResult{Value: sdkDefaultValue, VariationResult: offlineVariationResult}, nil
}
Expand Down
Loading