Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade nikunjy/rules module #347

Merged

Conversation

juliandanciu
Copy link
Contributor

@juliandanciu juliandanciu commented Sep 20, 2022

Description

I updated this module to depend on a newer version of nikunjy/rules. Prior to this, I updated nikunjy/rules to depend on antlr/v4 (antlr broke backwards compatibility)

I'm a bit uncertain if we should instead make nikunjy/rules v2 first.

I ran
go get github.com/nikunjy/rules@master; go mod tidy -compat=1.17 from master.
Pull request: nikunjy/rules#26

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-compatible and/or changes current functionality)

Closes issue(s)

Resolve #348

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /docs)
  • I have followed the contributing guide

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@juliandanciu juliandanciu changed the title go get github.com/nikunjy/rules@master; go mod tidy -compat=1.17 upgrade nikunjy/rules module Sep 20, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.096% when pulling 3ce4967 on juliandanciu:upgrade_nikunjy_rules_module into c6b627a on thomaspoignant:main.

@thomaspoignant
Copy link
Owner

We should probably move to nikunjy/rules v2.0.0 but we should check the compatibility first.
I'll open an issue to keep track of this when releasing the version 1.0.0.

@thomaspoignant thomaspoignant merged commit b1f6f08 into thomaspoignant:main Sep 22, 2022
@juliandanciu
Copy link
Contributor Author

We should probably move to nikunjy/rules v2.0.0 but we should check the compatibility first. I'll open an issue to keep track of this when releasing the version 1.0.0.

Okay. I opened a pull request for nikunjy/rules to create a v2 directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade nikunjy/rules module
3 participants