Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RawVariation method for proxy calls #241

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

thomaspoignant
Copy link
Owner

Description

Adding a new function called RawVariation.
This method doesn't care about the type of the result and forwards it as an interface.

This is needed if you want to expose the results as json, this will be used by go-feature-flag relay proxy that is an API exposition of go-feature-flag.

I did not add any documentation because it is not required to use this function in normal usage of the library.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-compatible and/or changes current functionality)

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have followed the contributing guide

@thomaspoignant thomaspoignant self-assigned this May 10, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 94.291% when pulling 40ef76d on raw-variation into 7aa04a0 on main.

@thomaspoignant thomaspoignant merged commit 4f41b32 into main May 10, 2022
@thomaspoignant thomaspoignant deleted the raw-variation branch May 10, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants