Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variation return default value only if an error appear #24

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Variation return default value only if an error appear #24

merged 3 commits into from
Dec 18, 2020

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Dec 18, 2020 •
edited
Loading

Description

When you call variation methods you get the default result only if you have an error.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-comptible and/or changes current functionality)

Closes issue(s)

Resolve #22
Resolve #21

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the Readme
  • I have followed the contributing guide

@thomaspoignant thomaspoignant added the enhancement New feature or request label Dec 18, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thomaspoignant thomaspoignant merged commit 5c0bc13 into main Dec 18, 2020
@thomaspoignant thomaspoignant deleted the fix/variation-return-err branch December 18, 2020 08:53
thomaspoignant added a commit that referenced this pull request Oct 11, 2021
@thomaspoignant
Variation return default value only if an error appear (#24)
a152dd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(change) Variation should return an error with default value (Doc) Add explaination of supported format
1 participant
@thomaspoignant