-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Request body logging in debug level #2397
Conversation
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2397 +/- ##
==========================================
- Coverage 86.08% 86.02% -0.06%
==========================================
Files 102 102
Lines 3794 3801 +7
==========================================
+ Hits 3266 3270 +4
- Misses 402 405 +3
Partials 126 126 ☔ View full report in Codecov by Sentry. |
6734675
to
b75dd17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @augustinasrce thanks for your pull request.
This is a great addition to log the request body, but since we are using an existing middleware I am not sure why we need our own file in the middleware section, I would prefer that we include directly the middleware in the server.go
file as suggested.
Idea was to keep things simple, without big nested structures (in case it gets bigger). Since it's quite small at the moment I'll update PR as You suggested. |
|
Description
Please add a description of what your pull request is doing.
Closes issue(s)
#2396
Checklist
README.md
and/website/docs
)