Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Notifier and DiffCache public #227

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Make Notifier and DiffCache public #227

merged 2 commits into from
Apr 8, 2022

Conversation

thomaspoignant
Copy link
Owner

Description

Make Notifier and DiffCache public to allow people to create there own Notifier.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-compatible and/or changes current functionality)

Closes issue(s)

Resolve #214

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /docs)
  • I have followed the contributing guide

@coveralls
Copy link

coveralls commented Apr 8, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 94.744% when pulling a35be54 on fix/214 into 50ed358 on main.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thomaspoignant thomaspoignant merged commit 5d6ea56 into main Apr 8, 2022
@thomaspoignant thomaspoignant deleted the fix/214 branch April 8, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(change) Make Notifier interface publicly implementable
2 participants
@thomaspoignant @coveralls