New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose FeatureEvent publicly #226

Merged

thomaspoignant merged 2 commits into main from fix/224

Apr 8, 2022

Owner

thomaspoignant commented Apr 8, 2022

Description

It was not possible to implement a custom Exporter because FeatureEvent was in the internal package.
Now FeatureEvent is in the ffexporter package so we are able to create custom Exporter.

Changes include

Bugfix (non-breaking change that solves an issue)
New feature (non-breaking change that adds functionality)
Breaking changes (change that is not backward-compatible and/or changes current functionality)

Closes issue(s)

Resolve #224

Checklist

I have tested this code
I have added unit test to cover this code
I have updated the documentation (README.md and /docs)
I have followed the contributing guide

Thomas Poignant added 2 commits

April 8, 2022 17:45


          fix 224: expose FeatureEvent publicly

0f2ea65


          Update documentation with the right package name

51e0ed5

sonarqubecloud bot commented Apr 8, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

coveralls commented Apr 8, 2022 •

edited

Loading

Coverage decreased (-1.1%) to 94.744% when pulling 51e0ed5 on fix/224 into 8719fb7 on main.

thomaspoignant merged commit 50ed358 into main

thomaspoignant deleted the fix/224 branch

April 8, 2022 15:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet