Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docker labels of the OCI Image Format Specification #2258

Merged

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Aug 24, 2024

Description

This PR adds pre-defined labels of the OCI Image Specification to the Docker images.
Also updates the homepage URLs of the Homebrew formulae.

Closes issue(s)

Resolve #2249.

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Aug 24, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 9b14f48
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/66c96c8a86c5570008065933

@itchyny itchyny force-pushed the docker-image-oci-spec-labels branch from 73e46b6 to 10d8ce0 Compare August 24, 2024 05:01
@itchyny itchyny changed the title Add docker labels of the OCI Image Format Specification feat: add docker labels of the OCI Image Format Specification Aug 24, 2024
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.00%. Comparing base (5b3bd3b) to head (9b14f48).
Report is 47 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2258   +/-   ##
=======================================
  Coverage   86.00%   86.00%           
=======================================
  Files         102      102           
  Lines        3731     3731           
=======================================
  Hits         3209     3209           
  Misses        399      399           
  Partials      123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itchyny itchyny force-pushed the docker-image-oci-spec-labels branch from 10d8ce0 to 9b14f48 Compare August 24, 2024 05:15
Copy link

@thomaspoignant
Copy link
Owner

Thanks for the pull request, i will review it when I am back and it will be available in the next version of GO Feature Flag.

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, I like the fact we provide more information 👌.
This will be available in the next release 🚀 .

@thomaspoignant thomaspoignant merged commit ff08839 into thomaspoignant:main Sep 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature) Add pre-defined labels of the OCI Image Format Specification to Docker images
2 participants